Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix cht flamelet solver #2067

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

EvertBunschoten
Copy link
Member

@EvertBunschoten EvertBunschoten commented Jul 3, 2023

Proposed Changes

The conjugate heat variables were not communicated properly between the flow and flamelet solver, resulting in the interface temperature between the fluid and solid to be always maintained at 300 kelvin for flamelet simulations. The changes mainly regard the recognition of the inclusion of energy for flamelet problems for the CHT methods, while in the flamelet solver, the conjugate variables are obtained from the flow solver instead of the flamelet solver itself.

Related Work

Related work includes the pull requests regarding the flamelet solver, as well as the related regression tests. The latter were obtained with this bug included, so the solution files have to be updated and the residual values in the regression tests have to be updated.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@EvertBunschoten EvertBunschoten self-assigned this Jul 3, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@pcarruscag pcarruscag changed the base branch from master to develop July 3, 2023 15:56
@EvertBunschoten EvertBunschoten changed the title [WIP]Bug fix cht flamelet solver Bug fix cht flamelet solver Jul 5, 2023
@EvertBunschoten EvertBunschoten marked this pull request as ready for review July 5, 2023 10:38
@pcarruscag pcarruscag merged commit a24c731 into develop Jul 6, 2023
@pcarruscag pcarruscag deleted the bug_fix_cht_flamelet_solver branch July 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants