-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writing of multiple inlet profiles when using MPI #1999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this testable somehow? Maybe a filediff regression that produces the example file?
Yes, when @danielmayer has merged the PR where we can compare output files, we can compare an existing inlet.dat with the newly created example_inlet.dat. I'll put that on the to-do list (I'll create an issue). |
Proposed Changes
SU2 writes an inlet profile for you when none is present and
SPECIFIED_INLET_PROFILE= YES
. When there are multiple inlets, and when using mpi, the routine fails because the total number of inlet profilesmaxProfiles
was not the total number of inlet profiles but only the maximum number of inlet profiles encountered in a rank. Some other info was also not communicated like column names and column values. This fixes the issue.Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
Reported here:
https://www.cfd-online.com/Forums/su2/248779-inlet-profile-su2-fluid-mixture.html
And connected to PR #1786
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.