Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing of multiple inlet profiles when using MPI #1999

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

SU2 writes an inlet profile for you when none is present and SPECIFIED_INLET_PROFILE= YES . When there are multiple inlets, and when using mpi, the routine fails because the total number of inlet profiles maxProfiles was not the total number of inlet profiles but only the maximum number of inlet profiles encountered in a rank. Some other info was also not communicated like column names and column values. This fixes the issue.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

Reported here:
https://www.cfd-online.com/Forums/su2/248779-inlet-profile-su2-fluid-mixture.html
And connected to PR #1786

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted linked an issue Apr 3, 2023 that may be closed by this pull request
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this testable somehow? Maybe a filediff regression that produces the example file?

@bigfooted
Copy link
Contributor Author

bigfooted commented Apr 4, 2023

Is this testable somehow? Maybe a filediff regression that produces the example file?

Yes, when @danielmayer has merged the PR where we can compare output files, we can compare an existing inlet.dat with the newly created example_inlet.dat. I'll put that on the to-do list (I'll create an issue).

@bigfooted bigfooted merged commit 0829072 into develop Apr 4, 2023
@bigfooted bigfooted deleted the fix_parallel_profile_write branch April 4, 2023 11:15
@pr-triage pr-triage bot added the PR: merged label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing inlet profile fails with mpi + multiple inlets
2 participants