Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symmetry/Euler marker preprocessing logic with deforming markers #1933

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Fix Symmetry/Euler marker preprocessing logic with deforming markers #1933

merged 8 commits into from
Feb 21, 2023

Conversation

pcarruscag
Copy link
Member

Fixes #1931

bigfooted
bigfooted approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

WallyMaier
WallyMaier approved these changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcarruscag pcarruscag merged commit 60e47b6 into develop Feb 21, 2023
@pcarruscag pcarruscag deleted the fix_symmetry_logic_with_deform_marker branch February 21, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WallyMaier WallyMaier WallyMaier approved these changes

@bigfooted bigfooted bigfooted approved these changes

Assignees
No one assigned
Labels
changelog:fix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcarruscag @bigfooted @WallyMaier