-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC inlet for SST solver based on local conditions at the Inlet #1796
Conversation
It's what I feared: all SST tests that have inlet BCs are failing. Can it be set up in such a way that we end up with the same inlet boundary condition? |
After a discussion with @Cristopher-Morales, the inlet boundary condition modification was moved to the UniformInlet function. |
Hi @pcarruscag , Thank you so much for your comments. I went to some of the test cases that are failing and I noticed that some residuals are very different because they are being compared at 5 - 10 or 20 iterations but if I compare them after 100 iterations they are very similar. I have run the NICFD_nozzle in the tutorial test cases and I got the following results: I also run the turb_flatplate_sst.cfg test case in the vandv folder and I got the same residuals and the same solution. I read in the pull request of @bigfooted that he experienced the same issues with the test cases with the restart option. So I am not sure if the other test cases are failing for similar reasons. Do you have some insight about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for #1784 and then you can start updating what needs to be updated
@Cristopher-Morales you can change the file .github/workflows/regression.yml to point to your branch with updated restarts (look for -c develop in that file). |
Hi Pedro, I have updated the restart test cases. Please let me know if something else is missing. Thank you so much in advance!! |
Proposed Changes
The Boundary conditions in the SST turbulence model are based on the free stream conditions. However if we mix two stream with different fluid properties at the inlets, the Turbulent Kinetic Energy, omega and eddy viscosity at the inlets should be based on these local fluid properties. So in this pull request, we aim to use the known fluid properties at the inlets in order to set the BC for the SST model.
I can add a test case if it is needed.
Related Work
This pull request is related to #1784.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.