Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC inlet for SST solver based on local conditions at the Inlet #1796

Merged
merged 18 commits into from
Nov 17, 2022

Conversation

Cristopher-Morales
Copy link
Contributor

@Cristopher-Morales Cristopher-Morales commented Oct 26, 2022

Proposed Changes

The Boundary conditions in the SST turbulence model are based on the free stream conditions. However if we mix two stream with different fluid properties at the inlets, the Turbulent Kinetic Energy, omega and eddy viscosity at the inlets should be based on these local fluid properties. So in this pull request, we aim to use the known fluid properties at the inlets in order to set the BC for the SST model.
I can add a test case if it is needed.

Related Work

This pull request is related to #1784.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor

It's what I feared: all SST tests that have inlet BCs are failing. Can it be set up in such a way that we end up with the same inlet boundary condition?

SU2_CFD/src/solvers/CTurbSSTSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CTurbSSTSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CTurbSSTSolver.cpp Outdated Show resolved Hide resolved
@pcarruscag pcarruscag changed the title BC inlet SST solver based on fluid properties at the Inlet BC inlet for SST solver based on local conditions at the Inlet Oct 26, 2022
@bigfooted
Copy link
Contributor

After a discussion with @Cristopher-Morales, the inlet boundary condition modification was moved to the UniformInlet function.
At the moment the modification is restricted to species transport.

@pcarruscag pcarruscag marked this pull request as draft October 27, 2022 15:15
@pcarruscag pcarruscag changed the title BC inlet for SST solver based on local conditions at the Inlet [WIP] BC inlet for SST solver based on local conditions at the Inlet Oct 27, 2022
@Cristopher-Morales
Copy link
Contributor Author

Hi @pcarruscag , Thank you so much for your comments. I went to some of the test cases that are failing and I noticed that some residuals are very different because they are being compared at 5 - 10 or 20 iterations but if I compare them after 100 iterations they are very similar. I have run the NICFD_nozzle in the tutorial test cases and I got the following results:
residuals
solid-line: develop
dash-line: proposed BC_INLET
Also I got the same results in both cases:
results_NICFD

I also run the turb_flatplate_sst.cfg test case in the vandv folder and I got the same residuals and the same solution. I read in the pull request of @bigfooted that he experienced the same issues with the test cases with the restart option. So I am not sure if the other test cases are failing for similar reasons. Do you have some insight about this?
Thank you so much in advance :) .

@Cristopher-Morales Cristopher-Morales marked this pull request as ready for review November 11, 2022 16:32
@pr-triage pr-triage bot removed the PR: draft label Nov 11, 2022
@Cristopher-Morales Cristopher-Morales changed the title [WIP] BC inlet for SST solver based on local conditions at the Inlet BC inlet for SST solver based on local conditions at the Inlet Nov 11, 2022
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #1784 and then you can start updating what needs to be updated

@pcarruscag
Copy link
Member

@Cristopher-Morales you can change the file .github/workflows/regression.yml to point to your branch with updated restarts (look for -c develop in that file).
I thought I had commented this but maybe I forgot to press comment xD

@Cristopher-Morales
Copy link
Contributor Author

@Cristopher-Morales you can change the file .github/workflows/regression.yml to point to your branch with updated restarts (look for -c develop in that file). I thought I had commented this but maybe I forgot to press comment xD

Hi Pedro, I have updated the restart test cases. Please let me know if something else is missing. Thank you so much in advance!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants