Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent mass flow rate for axisymmetry #1780

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

The mass flow rate uses AxiFactor. The computation of axifactor in CIncEulerSolver::GetOutletProperties is inconsistent with GetAxiFactor in CFlowOutput.cpp, leading to a different mass flow rate used for the target mass flow rate boundary condition (reported as screen output) compared to the mass flow rate reported in the history file.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pcarruscag pcarruscag changed the title fix inconsistent mass flow rate for axisymmetry Fix inconsistent mass flow rate for axisymmetry Oct 5, 2022
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to move that function to CGeometry and re-use it.

SU2_CFD/src/solvers/CIncEulerSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CIncEulerSolver.cpp Outdated Show resolved Hide resolved
@bigfooted bigfooted merged commit 4f3e0af into develop Oct 5, 2022
@bigfooted bigfooted deleted the fix_outlet_massflow branch October 5, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants