Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D rotational periodicity #1563

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Fix 2D rotational periodicity #1563

merged 3 commits into from
Mar 16, 2022

Conversation

pcarruscag
Copy link
Member

Fixes #1562

@pcarruscag pcarruscag linked an issue Mar 13, 2022 that may be closed by this pull request
2D-ROTATIONAL PERIODIC BOUNDARY CONDITION BUG #1562
Closed
@pcarruscag pcarruscag mentioned this pull request Mar 13, 2022
Closed
WallyMaier
WallyMaier approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pcarruscag
pcarruscag commented Mar 14, 2022
View reviewed changes
TestCases/navierstokes/periodic2D/config.cfg Outdated Show resolved Hide resolved
TestCases/hybrid_regression.py Outdated Show resolved Hide resolved
TobiKattmann
TobiKattmann approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this lightning quick bugfix and the additional testcase with meshing script 💐
I guess I still have to get used to having small meshes in the code repo from now on :)

TestCases/navierstokes/periodic2D/sector.geo Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CSolver.cpp
Comment on lines +746 to +747
for (iVar = 1; iVar < 1+nDim; ++iVar) {
d_diDim[iVar-1] = rotBlock(iVar, iDim);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun with indices :)

TestCases/hybrid_regression.py Outdated Show resolved Hide resolved
@pcarruscag @TobiKattmann
Apply suggestions from code review
2a6da92 
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
@pcarruscag pcarruscag merged commit c8ccde5 into develop Mar 16, 2022
@pcarruscag pcarruscag deleted the fix_2d_periodic_rotation branch March 16, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiKattmann TobiKattmann TobiKattmann approved these changes

@WallyMaier WallyMaier WallyMaier approved these changes

Assignees
No one assigned
Labels
changelog:fix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D-ROTATIONAL PERIODIC BOUNDARY CONDITION BUG
3 participants
@pcarruscag @WallyMaier @TobiKattmann