Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the configuration file for the SA Neg test case #1559

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Improve the configuration file for the SA Neg test case #1559

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7cd5426
Improve the configuration file for the SA Neg test case
suargi Mar 10, 2022
3b74901
Update test values and iterations
suargi Mar 10, 2022
1220dfc
Update TestCases/turbulence_models/sa/rae2822/turb_SA_NEG_RAE2822.cfg
suargi Mar 15, 2022
017616f
Header warning
suargi Mar 15, 2022
ff22728
Merge branch 'develop' into fix_saneg_variant_testcase
suargi Mar 16, 2022
6d7dffd
Merge branch 'develop' into fix_saneg_variant_testcase
pcarruscag Mar 16, 2022
f749e52
Small change to trigger regression tests.
TobiKattmann Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,8 @@ def main():
turbmod_sa_neg_rae2822 = TestCase('turbmod_sa_neg_rae2822')
turbmod_sa_neg_rae2822.cfg_dir = "turbulence_models/sa/rae2822"
turbmod_sa_neg_rae2822.cfg_file = "turb_SA_NEG_RAE2822.cfg"
turbmod_sa_neg_rae2822.test_iter = 20
turbmod_sa_neg_rae2822.test_vals = [-2.004689, 0.742306, 0.497308, -5.265793, 0.809463, 0.062016]
turbmod_sa_neg_rae2822.test_iter = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why a reduced number of iterations would be beneficial? I would always tend to do more as small errors might accumulate enough only after a certain amount of iterations, to break the regression test. That scenario might not happen to frequently but as you also remove multigrid there should be some time freed-up, right :)

So feel free (from my point of view) to revert to 20 or higher if it doesnt cost minutes.

turbmod_sa_neg_rae2822.test_vals = [-1.094542, 3.161741, 2.333560, 2.864805, 1.494301, 0.530135]
turbmod_sa_neg_rae2822.su2_exec = "mpirun -n 2 SU2_CFD"
turbmod_sa_neg_rae2822.timeout = 1600
turbmod_sa_neg_rae2822.new_output = True
Expand Down
12 changes: 8 additions & 4 deletions TestCases/turbulence_models/sa/rae2822/turb_SA_NEG_RAE2822.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RESTART_SOL= NO
MACH_NUMBER= 0.729
%
% Angle of attack (degrees, only for compressible flows)
AOA= 2.31
AOA= 20.31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recon, the case still converges to a reasonable solution with that more aggressive AoA?

%
% Free-stream temperature (288.15 K by default)
FREESTREAM_TEMPERATURE= 288.15
Expand Down Expand Up @@ -61,7 +61,11 @@ NUM_METHOD_GRAD= WEIGHTED_LEAST_SQUARES
CFL_NUMBER= 2.5
%
% Adaptive CFL number (NO, YES)
CFL_ADAPT= NO
CFL_ADAPT= YES
%
% Parameters of the adaptive CFL number (factor down, factor up, CFL min value,
TobiKattmann marked this conversation as resolved.
Show resolved Hide resolved
% CFL max value )
CFL_ADAPT_PARAM= ( 0.5, 1.5, 400.0, 1000.0 )
%
% Number of total iterations
ITER= 99999
Expand All @@ -78,7 +82,7 @@ LINEAR_SOLVER_ITER= 20
% -------------------------- MULTIGRID PARAMETERS -----------------------------%
%
% Multi-Grid Levels (0 = no multi-grid)
MGLEVEL= 3
MGLEVEL= 0
%
% Multi-grid cycle (V_CYCLE, W_CYCLE, FULLMG_CYCLE)
MGCYCLE= W_CYCLE
Expand Down Expand Up @@ -164,4 +168,4 @@ SURFACE_FILENAME= surface_flow
OUTPUT_WRT_FREQ= 250
%
% Screen output fields
SCREEN_OUTPUT= (INNER_ITER, RMS_DENSITY, RMS_MOMENTUM-X, RMS_MOMENTUM-Y, RMS_NU_TILDE, LIFT, DRAG)
SCREEN_OUTPUT= (INNER_ITER, RMS_DENSITY, RMS_MOMENTUM-X, RMS_MOMENTUM-Y, RMS_NU_TILDE, LIFT, DRAG)
suargi marked this conversation as resolved.
Show resolved Hide resolved