Fix possible segfault using SetConsVarGradient #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtneedels
approved these changes
Sep 30, 2021
| @@ -1591,8 +1591,6 @@ void CNEMOEulerSolver::BC_Far_Field(CGeometry *geometry, CSolver **solver_contai | |||
| /*--- Primitive variables, and gradient ---*/ | |||
| visc_numerics->SetConservative(nodes->GetSolution(iPoint), | |||
| node_infty->GetSolution(0) ); | |||
| visc_numerics->SetConsVarGradient(nodes->GetGradient(iPoint), | |||
| node_infty->GetGradient(0) ); | |||
There was a problem hiding this comment.
So these are unnecessary? Looks good to me otherwise, as long as this doesn't cause any issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I removed the calls to SetConsVarGradient in NEMO. It was causing a segfault locally when running any viscous case, though I couldn't produce the issue on other machines. If anyone has an explanation, I'm all ears! These seem to be superfluous anyway.
Related Work
This is a continuation of PR #1375
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.