Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpDiLib Update #1369

Merged
merged 1 commit into from
Sep 13, 2021
Merged

OpDiLib Update #1369

merged 1 commit into from
Sep 13, 2021

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Sep 13, 2021

Proposed Changes

OpDiLib update.

Related Work

Fixes #1368.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@jblueh jblueh mentioned this pull request Sep 13, 2021
Closed
@jblueh jblueh linked an issue Sep 13, 2021 that may be closed by this pull request
Error while cloning SU2 repository on Windows #1368
Closed
TobiKattmann
TobiKattmann approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcarruscag
pcarruscag approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@jblueh jblueh merged commit 5ce84cc into develop Sep 13, 2021
@jblueh jblueh deleted the opdi_update branch September 13, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

@TobiKattmann TobiKattmann TobiKattmann approved these changes

Assignees
No one assigned
Labels
changelog:chore PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while cloning SU2 repository on Windows
3 participants
@jblueh @TobiKattmann @pcarruscag