Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test for adding in the implicit viscous solver for NEMO #1356

Closed
wants to merge 98 commits into from

Conversation

WallyMaier
Copy link
Contributor

Proposed Changes

This PR addresses adding in the Jacobians for the NEMO convective, viscous and source terms. Much improvement and testing is still needed, but I was hoping to get feedback on some coding methodologies/strategies to avoid code bloat, etc.

I would very much appreciate thoughts and feedback!

Related Work

This is a continuation of the recent NEMO improvements/modernization #1343 and #1347

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@WallyMaier
Copy link
Contributor Author

@pcarruscag, I hope this is the last question, it seems the Matrix<NSPECIES, NSPECIES> dJdr_I causes some issues : "subscripted value is neither array nor pointer nor vector" when trying to anything with it. However, it seems all the other matrices dont have any issues. Do you have any ideas?

meson_scripts/init.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request introduces 2 alerts when merging 471a34a into c531be4 - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type
  • 1 for Comparison of narrow type with wide type in loop condition

@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2021

This pull request introduces 2 alerts when merging c0979aa into b718c1f - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type
  • 1 for Comparison of narrow type with wide type in loop condition

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 1 alert when merging ab8db24 into b718c1f - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request introduces 1 alert and fixes 16 when merging 50c2352 into b718c1f - view on LGTM.com

new alerts:

  • 1 for Multiplication result converted to larger type

fixed alerts:

  • 16 for Comparison of narrow type with wide type in loop condition

@WallyMaier WallyMaier closed this Nov 3, 2021
@WallyMaier WallyMaier deleted the feature_NEMO_implicit branch November 9, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants