-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Test for adding in the implicit viscous solver for NEMO #1356
Conversation
…into feature_NEMO_implicit
Signed-off-by: jtneedels <jneedels@stanford.edu>
…into feature_NEMO_implicit
This reverts commit 0b09437.
@pcarruscag, I hope this is the last question, it seems the Matrix<NSPECIES, NSPECIES> dJdr_I causes some issues : "subscripted value is neither array nor pointer nor vector" when trying to anything with it. However, it seems all the other matrices dont have any issues. Do you have any ideas? |
This pull request introduces 2 alerts when merging 471a34a into c531be4 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging c0979aa into b718c1f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ab8db24 into b718c1f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert and fixes 16 when merging 50c2352 into b718c1f - view on LGTM.com new alerts:
fixed alerts:
|
Proposed Changes
This PR addresses adding in the Jacobians for the NEMO convective, viscous and source terms. Much improvement and testing is still needed, but I was hoping to get feedback on some coding methodologies/strategies to avoid code bloat, etc.
I would very much appreciate thoughts and feedback!
Related Work
This is a continuation of the recent NEMO improvements/modernization #1343 and #1347
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.