"Did you mean...?" (make config errors more helpful) #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WallyMaier
reviewed
Apr 27, 2021
| @@ -2862,34 +2860,61 @@ void CConfig::SetConfig_Parsing(istream& config_buffer){ | |||
| if (!option_name.compare("RELAXATION_FACTOR_ADJFLOW")) | |||
| newString.append("Option RELAXATION_FACTOR_ADJFLOW is now RELAXATION_FACTOR_ADJOINT, " | |||
| "and it also applies to discrete adjoint problems.\n\n"); | |||
| if (!option_name.compare("WRT_MESH_QUALITY")) | |||
| else if (!option_name.compare("WRT_MESH_QUALITY")) | |||
There was a problem hiding this comment.
Wouldn't this prevent multiple warnings from being printed? Not sure if that's the point (or Im misunderstanding).
There was a problem hiding this comment.
No, those checks for deprecated options were already mutually exclusive.
You get multiple messages from the outer loop over all options in the config, and so you will also get multiple "did you mean?"s if you misspell more than one option.
There was a problem hiding this comment.
Ahh I missed the outer loop. Thanks.
WallyMaier
approved these changes
Apr 27, 2021
pcarruscag
commented
Apr 28, 2021
| } | ||
| if (Kind_SU2 == SU2_COMPONENT::SU2_CFD) { | ||
| SU2_MPI::Error(string("SU2_CFD: Config option DIRECT_DIFF= YES requires AD or complex support!\n") + | ||
| string("Please use SU2_CFD_DIRECTDIFF (configuration/compilation is done using the preconfigure.py script)."), |
There was a problem hiding this comment.
please make this meson.py in #1272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
suggest an alternative for unrecognized options
list the enum alternatives when an invalid one is used