Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEMO - link with mutation++ #1160

Merged
merged 75 commits into from
Jan 15, 2021
Merged

NEMO - link with mutation++ #1160

merged 75 commits into from
Jan 15, 2021

Conversation

CatarinaGarbacz
Copy link
Contributor

@CatarinaGarbacz CatarinaGarbacz commented Jan 12, 2021

Proposed Changes

This PR
-changes the name of the class CUserDefinedTCLib to CSU2TCLib (class that refers to the SU2 native fluid model for nonequilibrium flows)
-introduces another nonequilibrium fluid model that refers to the support of Mutation++ library. CMutationTCLib class is introduced at the same level of CSU2TCLib, as a child of CFluidModel
-sets up the meson configuration of Mutation++ as a git submodule (since Mutation++ is a cmake library, it needs to be treated as meson subproject)

For appropriate review of this PR

  1. please test the link to mutation++ with:
    $./meson.py <build_dir> --prefix=<path_to_su2> -Denable-mpp=true
    and follow the instructions at the end of the meson log
  2. run the regression test in TestCases/nonequilibrium/viscwedge_mpp

Related Work

This PR follows a series of PRs to migrate the full NEMO solver to the develop/master branch, with @WallyMaier and @fmpmorgado .

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

fmpmorgado and others added 30 commits September 18, 2020 17:43
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks stop worrying about empty lines, blank spaces and what not, just run clang-format... it's going to look weird at first but you'll like the freedom of only worrying with the important stuff.
Anyway LGTM

Common/include/CConfig.hpp Outdated Show resolved Hide resolved
Common/src/CConfig.cpp Show resolved Hide resolved
Common/src/CConfig.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CNEMOEulerSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CNEMOEulerSolver.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/variables/CNEMOEulerVariable.cpp Outdated Show resolved Hide resolved
@CatarinaGarbacz CatarinaGarbacz merged commit ce6f487 into develop Jan 15, 2021
@CatarinaGarbacz CatarinaGarbacz deleted the feature_NEMO_merge_final branch January 15, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants