Restructure grid_movement and adt_structure, remove SU2_MSH and grid_adaptation #1035
Conversation
| }; | ||
| #include "./CADTBaseClass.hpp" | ||
| #include "./CBBoxTargetClass.hpp" | ||
| #include "../omp_structure.hpp" |
There was a problem hiding this comment.
There was quite some room for cutting down includes. I tried to include the bare minimum in the new files
| * \brief Class for storing the information needed in a node of an ADT. | ||
| * \author E. van der Weide | ||
| */ | ||
| struct CADTNodeClass { |
There was a problem hiding this comment.
This file, and the CBBoxTargetClass only contain structs but I still split them into their own header files. These don't have any cpp files associated with them
| if(guaranteedMinDist2 > other.guaranteedMinDist2) return false; | ||
| if(boundingBoxID < other.boundingBoxID) return true; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
All the functions here are inline, so there isn't a corresponding cpp file
| @@ -102,9 +102,6 @@ AC_ARG_ENABLE(CFD, | |||
| AC_ARG_ENABLE(DOT, | |||
| AS_HELP_STRING([--disable-DOT], [build the SU2_DOT executable (default = yes)]), | |||
| [build_DOT=$enableval], [build_DOT="yes"]) | |||
| AC_ARG_ENABLE(MSH, | |||
| AS_HELP_STRING([--disable-MSH], [build the SU2_MSH executable (default = yes)]), | |||
| [build_MSH=$enableval], [build_MSH="yes"]) | |||
There was a problem hiding this comment.
I wasn't a 100% sure I needed to do to this configure file. I just searched for MSH and deleted any offending lines. Let me know if something else needs to be done
|
I don't mind waiting. Most of these files aren't usually changed by PRs. I'll keep this up to date. |
|
They will be changed when the version number changes to 7.0.6, and git will tell you "deleted by us, modified by them" just a heads up. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
Proposed Changes
This PR breaks up the following files:
It also gets rid of grid_adaptation_structure and the entire SU2_MSH module. These files have not be updated in a long time are are deprecated. None of the new work in mesh adaptation by @bmunguia uses any of these routines.
Related Work
#583
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.