Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividing Iteration Classes #1015

Merged
merged 18 commits into from
Jun 18, 2020
Merged

Dividing Iteration Classes #1015

merged 18 commits into from
Jun 18, 2020

Conversation

talbring
Copy link
Member

@talbring talbring commented Jun 3, 2020

Proposed Changes

This divides the iteration files and adds a factory class for their creation. A rework of the iteration class is still necessary, but I don't have time to do that at the moment.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • [] I have added a test case that demonstrates my contribution, if necessary.
  • [] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

SU2_CFD/include/iteration/CAdjFluidIteration.hpp Outdated Show resolved Hide resolved
Comment on lines +94 to +97
/*!
* \brief Updates the containers for the fluid system.
* \param[in] ??? - Description here.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need documentation strings on the derived classes, especially on this class family this stuff is out of date all the time.

SU2_CFD/src/iteration/CIteration.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/iteration/CIteration.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/iteration/CIteration.cpp Outdated Show resolved Hide resolved
SU2_CFD/src/iteration/CFluidIteration.cpp Show resolved Hide resolved
@pcarruscag pcarruscag merged commit 967b62c into develop Jun 18, 2020
@pcarruscag pcarruscag deleted the iteration_class branch June 18, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants