Move FEM files #1001
Merged
Move FEM files #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdweide
approved these changes
May 24, 2020
There was a problem hiding this comment.
Seems all logical to me. I can split the files in smaller ones if you wish. However, the data structures of the FEM solver must be reorganized significantly in order to improve performance. So I prefer to do the splitting of the files when that work is started, if that is OK for your.
|
Sounds like a good compromise, no point doing the same work twice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Move fem_* files in Common to Common/fem/. Move inline function to the hpp.
I've also deleted some unnecessary functions that compilers can generate automatically.
I did not split the files to minimize conflicts (this way the files just show as renamed) and also because I don't have time to figure out how this should be organized.
Related Work
#583
PR Checklist