Enable @wordpress/stylelint-config
#44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agree. Let's wait for upstream improvement. |
|
see also WordPress/gutenberg#65681 |
|
Thank you for linking that @Mouvedia |
|
WordPress/gutenberg#66272 has been merged. |
|
Tests for the WordPress Stylelint config are now working. |
romainmenke
commented
Jan 18, 2025
| @@ -14,6 +14,9 @@ on: | |||
| stylelint-version-override: | |||
| type: string | |||
| description: The Stylelint version override | |||
| working-directory-is-workspace: | |||
There was a problem hiding this comment.
npm workspaces often assume that npm install and other commands are run from the project root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #39
Blocked on WordPress/gutenberg#59933
Gutenberg uses a bespoke setup to emulate workspaces.
I would like to avoid adding support for their custom setup and instead wait until they align with standard npm workspaces.