Patch parse tsconfig #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes tsconfig from tsc --init - typescript uses a custom json parser that allows comments
- fixes errors with commented tsconfigs that are perfectly fine with typescript but throw with own withCustomConfig
|
CI fails are unrelated because travis uses npm instead of yarn. This way it installs the dependencies according to the semver ranges instead of the lock file. Either lock to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default tsconfig.json from
tsc --initincludes various comment styles. Those are allowed by Typescript because they use their own json parser. However those configs throw withwithCustomConfigbecause of the usage of the nativeJSON.parse.This pull requests fixes this behavior by using the same function to parse tsconfig that Typescript uses.