This repository has been archived by the owner on Jun 30, 2024. It is now read-only.
add completion provider fixes #184 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The extension part looks good to me And maybe the owner will like the webpack part |
|
This is great, including the webpack setup. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a competionProvider so that css completions can be done properly.
The completionProvider is written in typescript and is packaged via Webpack, this should make it easier to add any future changes.
@julienp @linonetwo
Annoyingly in this one the Emmet snippets sometimes have higher priority and get in the way, I'm sure there's extra work that can be done here to avoid that, but its better than before