Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace react-live with react-runner #847

Merged
merged 3 commits into from
Mar 25, 2022
Merged

replace react-live with react-runner #847

merged 3 commits into from
Mar 25, 2022

Conversation

nihgwu
Copy link
Contributor

@nihgwu nihgwu commented Mar 1, 2022

better performance and SSR support

@vercel
Copy link

vercel bot commented Mar 1, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styledcomponents/styled-components/7y5NXjEn9zWs2UPRKqsSMBdrNdxy
✅ Preview: https://styled-components-git-fork-nihgwu-neo-r-ef3a11-styledcomponents.vercel.app

@nihgwu nihgwu force-pushed the neo/react-runner branch from 12a69c0 to 451738b Compare March 1, 2022 21:33
@nihgwu nihgwu force-pushed the neo/react-runner branch from 451738b to 39252cb Compare March 1, 2022 22:15
quantizor
quantizor approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to work well and confirmed the bundle savings. Thanks for taking this on!

@quantizor quantizor enabled auto-merge (squash) March 25, 2022 14:21
@quantizor quantizor merged commit 48e1d21 into styled-components:main Mar 25, 2022
@nihgwu
Copy link
Contributor Author

nihgwu commented Mar 25, 2022

@probablyup I'm just about to update the package, will create another PR

@nihgwu nihgwu mentioned this pull request Mar 25, 2022
Merged
@nihgwu nihgwu mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantizor quantizor quantizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nihgwu @quantizor