Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_but_latest incorrectly cancels reruns of a PR #84

Closed
RhinosF1 opened this issue May 9, 2021 · 7 comments
Closed

all_but_latest incorrectly cancels reruns of a PR #84

RhinosF1 opened this issue May 9, 2021 · 7 comments

Comments

@RhinosF1
Copy link

RhinosF1 commented May 9, 2021

See https://github.com/MirahezeBots/MirahezeBots/pull/513/checks?check_run_id=2540803138

@mikehardy
Copy link
Contributor

If you follow the link to the run that was canceled from the run you linked, it indicates a completely different run https://github.com/MirahezeBots/MirahezeBots/actions/runs/826031378

I do not think it canceled a rerun, in fact I have done reruns successfully with all_but_latest, but the reason I investigated this report and was curious is because it may have been a cross-branch cancel like I saw recently: #82

The timing of the two runs fits the cross-branch cancel hypothesis as they were running at nearly the same time

@RhinosF1
Copy link
Author

I assumed it was the re-run because I've tried restarting it numerous times and every time it cancels it.

@mikehardy
Copy link
Contributor

🤔 that data does not fit my hypothesis at all - definitely fits yours assuming no other workflows are running and it just self-cancels each time. Confusing that the the cancel workflow action indicates it was canceling a different run though...

@RhinosF1
Copy link
Author

Yeah I filed it with this title because it's the only thing that made sense to me

@RhinosF1
Copy link
Author

I've only been rerunning that single workflow

RhinosF1 added a commit to FOSSBots/MirahezeBots that referenced this issue May 12, 2021
@RhinosF1
Copy link
Author

Disabling all_but_latest still causes this - FOSSBots/MirahezeBots#513

RhinosF1 added a commit to FOSSBots/MirahezeBots that referenced this issue Jun 1, 2021
* Make tests a package

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* Update and rename tests/__init__.py to MirahezeBots/tests__/init__.py

* Format code with autopep8 and isort

* Rename tests/models.py to MirahezeBots/tests/models.py

* Rename MirahezeBots/tests__/init__.py to MirahezeBots/tests/__init__.py

* Update and rename tests/test_general.py to MirahezeBots/tests/test_general.py

* Format code with autopep8 and isort

* Update .deepsource.toml

* Update MANIFEST.in

* Update workflow.yml

* Update workflow.yml

* Make compat a hard gate

* Delete compatible.yml

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

until styfle/cancel-workflow-action#84

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
MacFan4000 pushed a commit to FOSSBots/MirahezeBots that referenced this issue Jun 23, 2021
* Make tests a package

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* Update and rename tests/__init__.py to MirahezeBots/tests__/init__.py

* Format code with autopep8 and isort

* Rename tests/models.py to MirahezeBots/tests/models.py

* Rename MirahezeBots/tests__/init__.py to MirahezeBots/tests/__init__.py

* Update and rename tests/test_general.py to MirahezeBots/tests/test_general.py

* Format code with autopep8 and isort

* Update .deepsource.toml

* Update MANIFEST.in

* Update workflow.yml

* Update workflow.yml

* Make compat a hard gate

* Delete compatible.yml

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

until styfle/cancel-workflow-action#84

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>
MacFan4000 added a commit to FOSSBots/MirahezeBots that referenced this issue Jun 23, 2021
* Bump requests-cache from 0.6.2 to 0.6.3

Bumps [requests-cache](https://github.com/reclosedev/requests-cache) from 0.6.2 to 0.6.3.
- [Release notes](https://github.com/reclosedev/requests-cache/releases)
- [Changelog](https://github.com/reclosedev/requests-cache/blob/master/HISTORY.md)
- [Commits](requests-cache/requests-cache@v0.6.2...v0.6.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump requests-cache from 0.6.3 to 0.6.4 (#524)

Bumps [requests-cache](https://github.com/reclosedev/requests-cache) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/reclosedev/requests-cache/releases)
- [Changelog](https://github.com/reclosedev/requests-cache/blob/master/HISTORY.md)
- [Commits](requests-cache/requests-cache@v0.6.3...v0.6.4)

---
updated-dependencies:
- dependency-name: requests-cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* requirements: remove pingpong as it is now archived

* Update requirements.txt

* require: bump minimums (#490)

* setup: end support for Python 3.6

* Update SECURITY.md

* Update README.md

* Update compatible.yml

* Update workflow.yml

* Update workflow.yml

* require: bump minimums

* update

Co-authored-by: MacFan4000 <paulfkeffer@gmail.com>

* Update dev requirements

Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* update email ins security policy

* setup: end support for Python 3.6 / CI: remove 3.8-dev (#482)

* setup: end support for Python 3.6

* Update SECURITY.md

* Update README.md

* Update compatible.yml

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* re-enable 3.10-dev

* Bump actions/setup-python from 2 to 2.2.2 (#516)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 2.2.2.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v2.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* Bump actions/checkout from 2 to 2.3.4 (#515)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v2.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* Run push/pr_target always; make tests a package (#517)

* Make tests a package

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* Update and rename tests/__init__.py to MirahezeBots/tests__/init__.py

* Format code with autopep8 and isort

* Rename tests/models.py to MirahezeBots/tests/models.py

* Rename MirahezeBots/tests__/init__.py to MirahezeBots/tests/__init__.py

* Update and rename tests/test_general.py to MirahezeBots/tests/test_general.py

* Format code with autopep8 and isort

* Update .deepsource.toml

* Update MANIFEST.in

* Update workflow.yml

* Update workflow.yml

* Make compat a hard gate

* Delete compatible.yml

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

until styfle/cancel-workflow-action#84

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* rm

Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* Update links

Update links to new website.

* Update README.md

* Freenode > Libera

Dropped channel from url, as it doesn't actually send you to the channel.

* Create .flake8

* updates

* switch to non-deprecated BooleanAttribute

Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

* use old line limit for now

* Update dbclean.py

* no bandit

* Update requirements.txt

* Update workflow.yml

* Update README/SECURITY and bump + add changelog notes

Signed-off-by: MacFan4000 <paulfkeffer@gmail.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: RhinosF1 <rhinosf1@gmail.com>
Co-authored-by: sario528 <28790463+sario528@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
@styfle
Copy link
Owner

styfle commented Jul 29, 2021

Please try 0.9.1 to see if it fixes the issue (assuming this is related to #82)

@styfle styfle closed this as completed Sep 3, 2021
MacFan4000 pushed a commit to FOSSBots/MirahezeBots that referenced this issue Feb 23, 2022
* Make tests a package

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* Update and rename tests/__init__.py to MirahezeBots/tests__/init__.py

* Format code with autopep8 and isort

* Rename tests/models.py to MirahezeBots/tests/models.py

* Rename MirahezeBots/tests__/init__.py to MirahezeBots/tests/__init__.py

* Update and rename tests/test_general.py to MirahezeBots/tests/test_general.py

* Format code with autopep8 and isort

* Update .deepsource.toml

* Update MANIFEST.in

* Update workflow.yml

* Update workflow.yml

* Make compat a hard gate

* Delete compatible.yml

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

until styfle/cancel-workflow-action#84

* Update workflow.yml

* Update workflow.yml

* Update workflow.yml

* 3.7: start work to remove

Don't merge until 3.10 release day

* Update README.md

* Update SECURITY.md

* Update workflow.yml

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants