fix: load epub cover with missing metadata and misc improvements #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that if an epub manifest/meta didn't have an entry for a cover image, then no image would be loaded. There is now workaround logic for epubs without this metadata. I also tried to tidy some of that older epub code.
Separately, there is an extremely annoying bug I worked around with a temporary fix, but that will have to be handled another time more efficiently. I'm hesitant to do much outside of CI and the UI overhaul because I don't want to deal with annoying conflicts lol so am making this PR to get the changes in develop.