🐛 Enforce case-insensitive username uniqueness #557
+29
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
I've adjusted the
username
column manually to addCOLLATE NOCASE
according to https://www.prisma.io/docs/orm/prisma-client/queries/case-sensitivity#sqlite-provider. I've also adjusted the frontend validation to ignore case when comparing.I have tested manual DB insertion/updates and confirmed the migration enforces case-insensitive usernames (e.g.,
oromei
orOrOmEI
are equal). I'll try to do another validation pass tomorrow before merging, though. Edit to add that I've also tested the migration doesn't blow up my user or existing preferences, which is good I guess lol