Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix TemplateRegistrationFailed error when sending email #550

Draft
wants to merge 1 commit into
base: experimental
Choose a base branch
from

Conversation

aaronleopold
Copy link
Collaborator

Resolves #549

I've included the default templates in the binary, something I previously forgot to do. This should fix the issue, but I have to do some actual verification before I am comfortable merging this in.

I also took the time over lunch to actually write some documentation for the email feature. It isn't the best, but better than it was (i.e., nothing lol)

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
crates/email/src/template.rs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Should resolve #549, and added supporting documentation
@aaronleopold aaronleopold force-pushed the al/fix-email-templates branch from ea70c9c to 584767d Compare January 7, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant