💄 Improve small topbar nav issues #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial effort towards #488
82b20f4 to
40de21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488
I've made small, hopefully net-positive, changes to the topbar to render the insides a bit cleaner. I did not embed a submenu inside the topbar because I hate nested menus and really want to avoid them when I can, instead I made sure there is a button for starting a scan in the library settings. I think this is enough to satisfy the linked issue imo.
As a note, I think the topbar layout is weak in UX when compared to the sidebar and eventually it would be nice to give it more love than what I had time here to do.