Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Server housekeeping #499

Merged
merged 1 commit into from
Nov 5, 2024
Merged

🎨 Server housekeeping #499

merged 1 commit into from
Nov 5, 2024

Conversation

JMicheli
Copy link
Collaborator

@JMicheli JMicheli commented Nov 4, 2024

This pull request just does a couple of things:

  1. It boxes the QueryError in APIError, which silences a clippy warning.
  2. It walks back the silly each-item-individually change I made in routers::api::v1 for exported values. That was messy.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/server/src/errors.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
apps/server/src/routers/api/mod.rs 0.00% <ø> (ø)
apps/server/src/errors.rs 26.02% <0.00%> (ø)

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@aaronleopold aaronleopold merged commit c7b6e9c into experimental Nov 5, 2024
8 checks passed
@aaronleopold aaronleopold deleted the jm/housekeeping branch November 5, 2024 23:04
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants