Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Exclude cover image from double spread and fix rtl #491

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

smldub
Copy link
Contributor

@smldub smldub commented Oct 25, 2024

  • The first page is the cover, so it should be shown by itself instead of in double spread (maybe this could be optional)
    • requires skip variable to make it possible to go back to page 1 (else it will try to subtract two pages from page 2)
  • Reading right to left vs left to right requires flipping the ordering of the pages

(never coded a line of javascript before tonight, so sorry if it the code is awful...)

 - The first page is the cover, so it should be shown by itself instead of in double spread
 - Reading right to left vs left to right requires flipping the ordering of the pages.
@aaronleopold
Copy link
Collaborator

Thanks so much for fixing this! I'm traveling for work but will give it a proper look once I return

@aaronleopold aaronleopold changed the title Double Spread Reader fix 🐛 Exclude cover image from double spread Oct 26, 2024
@aaronleopold aaronleopold changed the base branch from main to develop October 26, 2024 03:52
@aaronleopold aaronleopold changed the title 🐛 Exclude cover image from double spread 🐛 Exclude cover image from double spread and fix rtl Oct 26, 2024
@aaronleopold aaronleopold merged commit a3a8c85 into stumpapp:develop Oct 27, 2024
7 checks passed
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants