-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ KoReader sync and API keys #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to #239
This was
linked to
issues
Oct 23, 2024
I'm aiming to merge this in over next few days / the weekend. I'll be sure to annotate this as an experimental feature in the docs, so even when it makes its way to stable at some point people understand (hopefully) it requires more user testing and validation |
aaronleopold
changed the title
[WIP] ✨ KoReader sync and API keys
✨ KoReader sync and API keys
Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #239
Resolves #447
I'm opening this PR a bit early as a draft to get some debug builds out into the world, hopefully testing these features and finding any holes before merging to experimental.
This PR primarily implements the KoReader sync API in Stump, but I had to build out API key support to unblock a koreader-specific auth constraint. An overview is as follows:
ENABLE_KOREADER_SYNC
is set totrue
feature:koreader_sync
permissionfeature:api_keys
permissionhttp(s)://your-server(:10801)(/baseUrl)/opds/(api_key)/v1.2/catalog
We are likely a few weeks out before this PR is ready for merge. Besides testing, there are some management features missing on the UI (i.e. delete) and I want to take the time to add thoughtful tests
Obligatory sneak peeks