Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cursor-based media queries #487

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

aaronleopold
Copy link
Collaborator

The primary issue which this fixes is passing afterId instead of cursor in the cursor-based API call. I've taken this as an opportunity to rewrite the horizontal scroller to use virtuoso instead of tanstack virtual

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/server/src/routers/api/v1/library.rs 0.00% 6 Missing ⚠️
apps/server/src/http_server.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
apps/server/src/http_server.rs 6.09% <0.00%> (-0.08%) ⬇️
apps/server/src/routers/api/v1/library.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold marked this pull request as ready for review October 21, 2024 05:46
@aaronleopold aaronleopold merged commit 87471d7 into experimental Oct 21, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/fix-horizontal-scrollers branch October 21, 2024 07:04
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant