🐛 Fix bug in FileExplorer that broke clicking on books.

[JMicheli]

I noticed an issue in the FileExplorer component that seems to have followed on the sdk overhaul. The function getBook defined here requires an sdk: Api parameter:

stump/packages/browser/src/components/explorer/FileThumbnail.tsx

Lines 112 to 134 in 2409a6e

	/**
	* A function that attempts to fetch the book associated with the file, if any exists.
	* The queryClient is used in order to properly cache the result.
	*/
	export const getBook = async (path: string, sdk: Api) => {
	try {
	const response = await queryClient.fetchQuery(
	[sdk.media.keys.get, { path }],
	() =>
	sdk.media.get({
	path: [path],
	}),
	{
	// 15 minutes
	cacheTime: 1000 * 60 * 15,
	},
	)
	return response.data?.at(0) ?? null
	} catch (error) {
	console.error(error)
	return null
	}
	}

However, a few calls to getBook didn't include the parameter, which caused them to fail. As a result, when double clicking a file in the explorer, you'd get this response:

The changes I made seem to fix it, but it would be good to have review by someone more familiar with React to make sure that any other changes that I may have missed are made.

[aaronleopold]

This looks perfect to me. Thanks for finding and fixing this issue!!

[aaronleopold]

I wonder why the lints didn't catch this. I'll have to revisit the frontend lint scripts

[JMicheli]

That's a good point, I found the problem easily because ESLint threw an error in VS Code and underlined it in red for me.

[JMicheli]

Well actually here's your answer: typescript-eslint/typescript-eslint#352 (comment)

The salient part:

we purposely do not care about errors that should arise as a result of type checking errors. We only care that the code is syntactically valid (i.e. can be parsed without errors), not about whether it's semantically valid (i.e. don't care if it is type sound).

We need to use tsc to catch this sort of thing.

[aaronleopold]

Ahh yeah, okay. That makes sense. I could have sworn I defined a tsc script somewhere to check types but I'll take a look tomorrow