Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor media API into multiple modules #477

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

JMicheli
Copy link
Collaborator

This is just a reorganization pull request, it does what a TODO comment suggested and removes everything in the (very large) single-file media.rs module out to a directory and separates the bulk, individual, and thumbnail operations.

It also removes all the apply_* filters from media and into a separate filters module (again, as suggested by the TODO). I also did the same for other such functions in other places to keep things organized.

@JMicheli JMicheli requested a review from aaronleopold October 14, 2024 14:51
@aaronleopold aaronleopold changed the title ♻️ Refactor media API per TODO item ♻️ Refactor media API into multiple modules Oct 14, 2024
Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! It's hard to get to each TODO I write, so I really appreciate you knocking it out. I didn't look too closely at the existing and relocated code, I'm going to trust it was moved without edits which seems to be the case for the handful I did scan through. I had a couple of unimportant questions, but they aren't blocking.

Oh I also renamed the PR to have more contextual meaning

apps/server/src/routers/api/mod.rs Show resolved Hide resolved
apps/server/src/routers/api/mod.rs Outdated Show resolved Hide resolved
@JMicheli
Copy link
Collaborator Author

Okay I think that fix addresses the only issue here. I'll let CI finish then merge late tonight unless you indicate otherwise.

@JMicheli JMicheli merged commit 0f34c96 into develop Oct 15, 2024
8 checks passed
@JMicheli JMicheli deleted the jm/api-refactor branch October 15, 2024 03:04
@aaronleopold aaronleopold mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants