♻️ Refactor upload image and add max_size #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was reading through the code while preparing to eventually handle the file upload/deletion/bulk management features, I happened on some code for uploading images with a todo marked asking to eventually add configurable max size.
That was easy enough, so I added it as a configuration variable with a default value equal to the prior 20 MB hard-coded limit. I also took the opportunity to refactor the code in the
upload
module so that it can be more easily reused when other upload types are added.