Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖥️ Desktop app server management #441

Merged
merged 25 commits into from
Sep 15, 2024
Merged

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Sep 10, 2024

This PR gives the desktop app some love by implementing the following:

  • Update tauri et al to latest v1 (I am not going to do a v2 migration yet)
  • Implement a persisted key/value store on the tauri side, primarily for saved server functionality
  • Refactor a lot of the existing rust code for the desktop app for safety (remove unwraps, add errors, etc)
  • Add type generation for desktop-specific types
  • Implement management suite for saved servers on the UI
    • Interact with the useTauriStore hook
    • Create / edit / delete / delete all
    • Switch to server (logout + change base URL)

Opening the PR early mostly to start testing the CI to ensure everything compiles okay. Before merge, I will add:

  • Select server screen when no server is set but the store has servers configured
  • Add tests to new components
    • I didn't add for each, I have limited time unfortunately. But I tried to add tests for the important ones
  • Ensure I didn't break anything on the webapp side of things

I want to note that these changes have implications, primarily that I am leaning towards always bundling the server with the desktop app but having the enablement a user setting. This is mostly because I don't necessarily want to have to build two versions of the app: one with the server and another without. I am leaving it feature flagged in the code in case I change my mind, I'd like to see how much bloat it realistically adds.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/server/src/routers/mod.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
apps/server/src/routers/mod.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold changed the title [WIP] 🖥️ Desktop app server management 🖥️ Desktop app server management Sep 14, 2024
@aaronleopold aaronleopold marked this pull request as ready for review September 14, 2024 21:17
@aaronleopold
Copy link
Collaborator Author

I did some additional testing, I think this is ready enough considering the desktop app is not part of the releases yet. There are definitely many things to work through before starting to include it in the releases, and I'll make a separate issue to record them

@aaronleopold aaronleopold merged commit 83d5032 into develop Sep 15, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/desktop-checkin branch September 15, 2024 00:39
@aaronleopold aaronleopold mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant