-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🖥️ Desktop app server management #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
aaronleopold
changed the title
[WIP] 🖥️ Desktop app server management
🖥️ Desktop app server management
Sep 14, 2024
I did some additional testing, I think this is ready enough considering the desktop app is not part of the releases yet. There are definitely many things to work through before starting to include it in the releases, and I'll make a separate issue to record them |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the desktop app some love by implementing the following:
tauri
et al to latest v1 (I am not going to do a v2 migration yet)unwraps
, add errors, etc)useTauriStore
hookOpening the PR early mostly to start testing the CI to ensure everything compiles okay. Before merge, I will add:
I want to note that these changes have implications, primarily that I am leaning towards always bundling the server with the desktop app but having the enablement a user setting. This is mostly because I don't necessarily want to have to build two versions of the app: one with the server and another without. I am leaving it feature flagged in the code in case I change my mind, I'd like to see how much bloat it realistically adds.