Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update dependencies #433

Merged
merged 1 commit into from
Sep 3, 2024
Merged

⬆️ Update dependencies #433

merged 1 commit into from
Sep 3, 2024

Conversation

JMicheli
Copy link
Collaborator

@JMicheli JMicheli commented Sep 2, 2024

This pull request updates a few of the dependencies to their latest version, just a little housekeeping.

The only substantive change is that the pdfium_render crate's latest version changed its interface so that you now have to import everything from the prelude module, e.g.,: use pdfium_render::prelude::{PdfRenderConfig, Pdfium}. Weird choice imo.

@JMicheli JMicheli changed the title Update dependencies ⬆️ Update dependencies Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
core/src/filesystem/error.rs 6.25% <ø> (ø)
core/src/filesystem/media/pdf.rs 32.14% <ø> (ø)

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

you now have to import everything from the prelude module, e.g.,: use pdfium_render::prelude::{PdfRenderConfig, Pdfium}

Yeah not my preference either

@aaronleopold aaronleopold merged commit ebbb8e5 into develop Sep 3, 2024
8 checks passed
@aaronleopold aaronleopold deleted the jm/update-deps branch September 3, 2024 03:20
@aaronleopold aaronleopold mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants