Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix docker build push #424

Merged
merged 5 commits into from
Aug 30, 2024
Merged

💚 Fix docker build push #424

merged 5 commits into from
Aug 30, 2024

Conversation

aaronleopold
Copy link
Collaborator

lol so I forgot to add --push when publishing the builds 🙃

@aaronleopold aaronleopold merged commit bef46c8 into develop Aug 30, 2024
6 checks passed
@aaronleopold aaronleopold deleted the al/fix-docker-push branch August 30, 2024 01:40
@aaronleopold
Copy link
Collaborator Author

So I have a suspicion that podman buildx, when used in this way for building multi-arch images, will overwrite the tag for whichever build happens last (since it is not parallel builds). If this is true, then the next nightly push will only have an arm64 build on dockerhub. This is obviously a problem. I'll divert my attention to the build system again this weekend 😭

@aaronleopold
Copy link
Collaborator Author

@aaronleopold
Copy link
Collaborator Author

So I have a suspicion that podman buildx, when used in this way for building multi-arch images, will overwrite the tag for whichever build happens last (since it is not parallel builds). If this is true, then the next nightly push will only have an arm64 build on dockerhub

Yup, it did just that: https://hub.docker.com/layers/aaronleopold/stump/nightly/images/sha256-2633f62ee8a4ed8fa3016cbfd441229e7eddc0fc2a1667181fd2b67297c1537e?context=explore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant