Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Scanner ignore rules and 💄 library settings refactor #422

Merged
merged 24 commits into from
Aug 30, 2024

Conversation

aaronleopold
Copy link
Collaborator

This PR has two distinct and large features:

  1. DB-level ignore rules to better control which files are scanned
  2. Redesign the library settings and library creation pages

I've overhauled the navigation for those two pages, I think it is a lot more organized but am open to feedback nonetheless. There are a few fixes in here, too, and odds and ends:

  • Add CI step for asserting the codegen is up-to-date
  • Fix the rimraf utility commands for quickly clearing the repo of node_modules
  • Fix the component which allows you to select tags for an entity, e.g. a library, and re-add it to forms where it was previously removed
  • Fix tag creation and linking/unlinking during library create/update
  • Add an initialize fn to the job manager
  • Add secret fun thing for certain milestones, e.g. creating a library
  • Add a ton of locale mappings to the library forms
    • Not 100% coverage yet, but I'll aim to get there before merging this in

.. And more, I'm sure I am forgetting something. There is still a good bit of work to go, and then review of what's changed, but I'm hoping to wrap this up either this weekend or the following one.

@aaronleopold
Copy link
Collaborator Author

This is looking pretty good so far!

In my testing I found a pretty gnarly regression in the scanner, unrelated to these changes though. I ran out of time to isolate/cherry-pick it to nightly today but I will aim to do it tomorrow. The commit with the tentative fix is: 61e7dbd

@aaronleopold aaronleopold marked this pull request as ready for review August 29, 2024 23:40
@aaronleopold aaronleopold merged commit 3ab0593 into experimental Aug 30, 2024
5 of 6 checks passed
@aaronleopold aaronleopold deleted the al/scan-exclusion-rules branch August 30, 2024 23:35
@aaronleopold aaronleopold linked an issue Sep 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Scanner ignore rules
1 participant