-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Scanner ignore rules and 💄 library settings refactor #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is looking pretty good so far! In my testing I found a pretty gnarly regression in the scanner, unrelated to these changes though. I ran out of time to isolate/cherry-pick it to |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two distinct and large features:
I've overhauled the navigation for those two pages, I think it is a lot more organized but am open to feedback nonetheless. There are a few fixes in here, too, and odds and ends:
rimraf
utility commands for quickly clearing the repo ofnode_modules
initialize
fn to the job manager.. And more, I'm sure I am forgetting something. There is still a good bit of work to go, and then review of what's changed, but I'm hoping to wrap this up either this weekend or the following one.