Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix OPDS thumbnail endpoint #414

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Aug 22, 2024

Fixes an issue where generated thumbnails aren't actually being loaded, rather the file is being opened. I also made a note for two items:

  • Improve a silly query
  • Support STRICT_OPDS configuration, which will convert any non-compliant OPDS images, rather than just always doing it

I will tackle both alongside the image serving work I plan to do this weekend

See Discord for additional context

@aaronleopold
Copy link
Collaborator Author

Verified locally:

  2024-08-22T23:20:37.594117Z TRACE stump_server::routers::api::v1::media: Found generated media thumbnail, path: "/Users/aaronleopold/.stump/thumbnails/ddcda452-eb6f-43c9-aac3-181a64f72fa3.png", media_id: "ddcda452-eb6f-43c9-aac3-181a64f72fa3"
    at apps/server/src/routers/api/v1/media.rs:1031
    in tower_http::trace::make_span::request with method: GET, uri: /opds/v1.2/books/ddcda452-eb6f-43c9-aac3-181a64f72fa3/thumbnail, version: HTTP/1.1

  2024-08-22T23:20:37.594424Z TRACE stump_server::routers::opds::v1_2: OPDS legacy image detected, returning as-is

Fixes an issue where generated thumbnails aren't actually being loaded, rather the file is being opened
@aaronleopold aaronleopold force-pushed the al/fix-opds-thumbnails branch from 0bad1a6 to 40d2c7a Compare August 22, 2024 23:21
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files Patch % Lines
apps/server/src/routers/opds/v1_2.rs 0.00% 3 Missing ⚠️
Files Coverage Δ
apps/server/src/routers/api/v1/media.rs 0.00% <ø> (ø)
apps/server/src/routers/opds/v1_2.rs 0.00% <0.00%> (ø)

@aaronleopold aaronleopold merged commit 77b4635 into develop Aug 23, 2024
8 checks passed
@aaronleopold aaronleopold deleted the al/fix-opds-thumbnails branch August 23, 2024 00:02
@aaronleopold aaronleopold mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant