🐛 Fix bug in WebpProcessor::generate
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
aaronleopold
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!!
I've retained my changes to
WebpProcessor::generate_from_pathbecause they allow tests to pass that, in my view, should pass. In any event, this function is not called within Stump at any point, so it is likely irrelevant.
I think this is the right call, at least for a small PR aimed at fixing a bug. We can reevaluate the trait and this particular struct's impl of it as needed 🙂
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts some changes made in #351 which inadvertently caused generating Webp thumbnails to fail.
The problem, as identified in the Discord by @fehwalker, was caused by changes to
WebpProcessor::generatewhich assumed that the input data was formatted as webp, meaning that attempts to convert non-webp images into webp would fail.I've retained my changes to
WebpProcessor::generate_from_pathbecause they allow tests to pass that, in my view, should pass. In any event, this function is not called within Stump at any point, so it is likely irrelevant.