Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix basic auth password parsing breaking on : character #375

Merged

Conversation

fehwalker
Copy link
Contributor

Fix issue where passwords containing : character break Basic Auth used on API endpoints (particularly OPDS).

@aaronleopold aaronleopold changed the title Fix basic auth password parsing breaking on : character 🐛 Fix basic auth password parsing breaking on : character Jul 31, 2024
Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much! There was a small lint issue but I went ahead and quickly fixed it. I'll merge this in once CI is ✅

@aaronleopold aaronleopold enabled auto-merge (squash) July 31, 2024 00:56
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Files Patch % Lines
apps/server/src/utils/auth.rs 84.61% 2 Missing ⚠️
apps/server/src/routers/api/mod.rs 0.00% 1 Missing ⚠️
Files Coverage Δ
core/src/filesystem/media/builder.rs 68.11% <100.00%> (ø)
apps/server/src/routers/api/mod.rs 0.00% <0.00%> (ø)
apps/server/src/utils/auth.rs 49.09% <84.61%> (ø)

@aaronleopold aaronleopold merged commit 2f8d53a into stumpapp:develop Jul 31, 2024
5 checks passed
@fehwalker fehwalker deleted the fix-basic-auth-password-parsing branch July 31, 2024 01:18
@aaronleopold aaronleopold mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants