Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add core tests to improve coverage #370

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Conversation

JMicheli
Copy link
Collaborator

This pull request adds additional tests to the core crate. So far I have added:

  • utils tests
  • filesystem/common tests
  • filesystem/archive tests

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 6 lines in your changes missing coverage. Please review.

Files Coverage Δ
core/src/config/mod.rs 11.76% <ø> (ø)
core/src/filesystem/archive.rs 97.77% <100.00%> (ø)
core/src/filesystem/common.rs 51.57% <100.00%> (ø)
core/src/utils.rs 100.00% <100.00%> (ø)
core/src/db/entity/notifier.rs 0.00% <0.00%> (ø)
core/src/db/entity/emailer/entity.rs 0.00% <0.00%> (ø)

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@aaronleopold aaronleopold merged commit c73dd31 into develop Jul 20, 2024
5 checks passed
@aaronleopold aaronleopold deleted the improve-coverage branch July 20, 2024 19:11
@aaronleopold aaronleopold mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants