-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Release server binary #369
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
I just pushed another commit that cleans up the testing stuff since this appears to be working. Won't be shocked if it requires further tuning, but I think it's likely ready to merge in. One thought: should it be merged with main instead since it probably needs to be for the action to be manually triggered, and that's where releases come from anyhow? |
It's okay to merge into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for knocking this out!
This pull request adds a new workflow to build and release a binary package of the Stump server, so that users can directly run the server rather than using a Docker container. It aims to close #310 once complete.
The workflow is intended to be manually triggered, with the desired version number/tag for the release being input at that time. For example, the user could trigger the workflow with
version = 1.0.0
and the result would be a draft release called "Release 1.0.0" tagged "v1.0.0."