Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Release server binary #369

Merged
merged 10 commits into from
Jul 20, 2024
Merged

👷 Release server binary #369

merged 10 commits into from
Jul 20, 2024

Conversation

JMicheli
Copy link
Collaborator

This pull request adds a new workflow to build and release a binary package of the Stump server, so that users can directly run the server rather than using a Docker container. It aims to close #310 once complete.

The workflow is intended to be manually triggered, with the desired version number/tag for the release being input at that time. For example, the user could trigger the workflow with version = 1.0.0 and the result would be a draft release called "Release 1.0.0" tagged "v1.0.0."

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@JMicheli JMicheli changed the title Initial release_binary workflow 👷 Release server binary Jul 17, 2024
@JMicheli
Copy link
Collaborator Author

I just pushed another commit that cleans up the testing stuff since this appears to be working. Won't be shocked if it requires further tuning, but I think it's likely ready to merge in.

One thought: should it be merged with main instead since it probably needs to be for the action to be manually triggered, and that's where releases come from anyhow?

@aaronleopold
Copy link
Collaborator

One thought: should it be merged with main instead since it probably needs to be for the action to be manually triggered, and that's where releases come from anyhow?

It's okay to merge into develop, it'll be in main before the next release (I create the tag after merge to main, which triggers the docker build)

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for knocking this out!

@aaronleopold aaronleopold merged commit ac0d723 into develop Jul 20, 2024
5 checks passed
@aaronleopold aaronleopold deleted the binary-release branch July 20, 2024 19:57
aaronleopold added a commit that referenced this pull request Jul 29, 2024
This builds off of the work from #369 to close #310
aaronleopold added a commit that referenced this pull request Jul 31, 2024
This builds off of the work from #369 to close #310
aaronleopold added a commit that referenced this pull request Aug 4, 2024
* 👷 Add `macOS` platform to binary release workflow

This builds off of the work from #369 to close #310

* 👷 Add path filters for CI tasks

* 🥪 lunch tweaks to add arm

* try test workflow

* Revert "try test workflow"

This reverts commit 7a1783b.
@aaronleopold aaronleopold mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants