Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix nested file structure support for ZIP/RAR format #353

Merged
merged 5 commits into from
Jun 22, 2024

Conversation

aaronleopold
Copy link
Collaborator

This PR corrects an issue where Stump incorrectly reads byte content (without unpacking) from archive files in the scenario where the underlying structure is nested, for example:

Comic book.cbz
  |_ ComicInfo.xml
  |_ Comic book folder
       |_ 000.jpg
       |   ...
       |_ 120.jpg

I've also adjusted some of the logic to cut the file reads for #327. Once I'm confident no other changes are necessary, this PR should be ready

@aaronleopold
Copy link
Collaborator Author

This is likely good to go, I'll give it another quick look over after work and then aim to merge it. I'll likely put out a 0.0.4 sometime in the next 1-2 weeks, too.

@aaronleopold aaronleopold changed the title [WIP] 🐛 Fix nested file structure support for ZIP/RAR format 🐛 Fix nested file structure support for ZIP/RAR format Jun 21, 2024
@aaronleopold aaronleopold marked this pull request as ready for review June 22, 2024 18:14
@aaronleopold aaronleopold merged commit 3aa02a7 into develop Jun 22, 2024
3 checks passed
@aaronleopold aaronleopold deleted the al/fix-nested-structures-zip branch June 22, 2024 18:37
@aaronleopold aaronleopold mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant