✅ Fix stump_config tests #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was investigating the failing tests as mentioned in the Discord earlier and I happened on a solution that seems sensible.
The crate temp-env provides a way to set environment variables, run a test, then unset those variables. Embedding the tests involving environment variables in this crate's wrapper both makes it more ergonomic and also fixes the inconsistent passing of tests that I was experiencing (I interpret this as confirming that the previous tests were causing some sort of race condition where the environment variables for each were fighting each other).
Also, I set the telegram and discord tests to be ignored since they rely on local variables being set. It's probably a good idea to fix those in the future, but this will also open the way for automated benchmarking since that will need to rely on running tests and gauging their performance anyway.