-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support grid and table layouts #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a LOT of duplication to cut down on, though
aaronleopold
added a commit
that referenced
this pull request
Apr 28, 2024
Backport the main stylistic fix from #322. This does not include some of the small improvements to the light mode, though, just the small fix.
This should be good to go, I'll let it go to experimental once CI is ✅ I didn't add column configuration options for each entity, but for books at least for now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #292
This PR overhauls the UI for all book and series exploration routes:
I also went through and reworded a few comments throughout the project to make them easier to find once the next prisma version is released. Super excited for that version, it will bring lots of goodies!
A few items left before merging:
Optionally refresh the file explorer with new scroll patternsClean up any missed and unused filesI'll tackle any unchecked items in a follow up at some point