Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support grid and table layouts #322

Merged
merged 18 commits into from
Apr 28, 2024
Merged

Conversation

aaronleopold
Copy link
Collaborator

@aaronleopold aaronleopold commented Apr 27, 2024

Resolves #292

This PR overhauls the UI for all book and series exploration routes:

  • Add table layout variant
    • Layout preferences are stored per-entity (book, series, library, etc) on the client
  • Fix awkward scrolling layout, add sticky header with useful filtering operations
    • Ordering/sorting, filtering, page constraints, etc
  • Redesign pagination
  • Add foundation for library explore pages (not yet implemented)
  • Redesign initial state (no libraries)
  • Slightly correct some theme color issues
  • Fix dark colors bleeding into light mode for a few navigation elements
  • Generalized a few common react-table-related Rust structs
  • Reorganize a few of the scene folders
  • Fixed invalid docs link

I also went through and reworded a few comments throughout the project to make them easier to find once the next prisma version is released. Super excited for that version, it will bring lots of goodies!

A few items left before merging:

  • Add configurable columns to the table layout variants
  • Add page selector to the redesigned pagination controls
  • Add page size config option
  • Optionally refresh the file explorer with new scroll patterns
  • Clean up any missed and unused files

I'll tackle any unchecked items in a follow up at some point

aaronleopold added a commit that referenced this pull request Apr 28, 2024
Backport the main stylistic fix from #322. This does not include some of the small improvements to the light mode, though, just the small fix.
@aaronleopold aaronleopold marked this pull request as ready for review April 28, 2024 18:23
@aaronleopold
Copy link
Collaborator Author

This should be good to go, I'll let it go to experimental once CI is ✅

I didn't add column configuration options for each entity, but for books at least for now

@aaronleopold aaronleopold merged commit 2f1b085 into experimental Apr 28, 2024
3 checks passed
@aaronleopold aaronleopold deleted the al/exploration-layouts branch April 28, 2024 18:57
@aaronleopold aaronleopold mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant