⬆️ Pre-0.0.2 housekeeping #305
Conversation
There was a problem hiding this comment.
This was a huge effort, I know managing dependency upgrades can be a bit tedious so I really appreciate you doing this!
I had a couple of nit picks of little importance, the one thing keeping me from approving and merging is that I think we need to bump the minimum rust version with these changes. Using the repo's configured 1.72.1 toolchain locally reported the following:
- jsonwebtoken requires 1.73.0
- clap_builder requires 1.74.0
| fn filter_if_hidden(entry: DirEntry) -> Option<DirEntry> { | ||
| let path = entry.path(); | ||
| let stem = path.file_stem().unwrap_or_default(); | ||
|
|
||
| // Remove hidden files starting with period | ||
| if stem.to_str().unwrap_or_default().starts_with('.') { | ||
| return None; | ||
| } | ||
|
|
||
| Some(entry) | ||
| } |
There was a problem hiding this comment.
Not important for this PR, but might be worth exporting PathUtils trait from stump_core so we don't maintain duplicate logic, e.g. PathUtils::is_hidden_file.
|
Any reason not to bump it up to 1.77.2 (the current stable release)? |
I don't think so, might as well give it a shot and see what CI says |
|
@JMicheli I updated the toolchain and a few other miscellaneous things (e.g. pdfium version, lints after updates, merge conflicts, etc). There was actually a clippy bug I found, too! Let me know if there's anything you want to add to this PR. I'll plan to merge this tomorrow after work, get a nightly image out, then 0.0.2 over the weekend. Thanks again for doing all of this cleanup! |
|
I won't have time today to do anything further, I say merge it if you're good to do so. |
This pull request is meant to do some general project housekeeping tasks.
It:
ThumbnailGenerationJob; andPauseJobandResumeJobtake anAcknowledgeableCommandparameter.