Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍻 POC EpubJS RN reader #289

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

aaronleopold
Copy link
Collaborator

Reorganized a bit of the reader screen to account for future readers a bit better, and added a really bare-bones EPUB reader. This frankly will not hold up in time, IMO, and I'll likely either have to move off of epubjs in favor of an alternative that works well with RN or just build something in house.

I don't think it is long for this world in the mobile app...
Copy link
Collaborator

@LRotenberger LRotenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronleopold aaronleopold marked this pull request as ready for review March 10, 2024 22:50
@aaronleopold aaronleopold merged commit aec4118 into experimental Mar 10, 2024
3 checks passed
@aaronleopold aaronleopold deleted the al/mobile-epubjs-reader branch March 10, 2024 22:52
@aaronleopold aaronleopold mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants