✨ Upload library/series/book thumbnails #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined API endpoints for uploading an image for book/series/library thumbnails (#202). Extracted validation logic to a separate fn. Will work on UI hookups next, most likely
Added support for GIF thumbnails
aaronleopold
added a commit
that referenced
this pull request
Jan 29, 2024
This reverts commit c50e2c1.
aaronleopold
added a commit
that referenced
this pull request
Jan 29, 2024
aaronleopold
added a commit
that referenced
this pull request
Jan 29, 2024
aaronleopold
added a commit
that referenced
this pull request
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #202
Relates to #133
PR adds minimal support for uploading custom images for library, series, and book thumbnails. I extended support to GIF files, as well.
The file size is capped to 20MB, and the error handling for this bound is not overly ideal yet (at least on the backend). I'd like to follow this up eventually with new configuration options for setting the max upload size, but for now it is hard coded. I'll likely revisit these once I start #133 more directly.