✨ Epub bookmark support #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug with the chapterName determination, refreshing the top and bottom bars for epub controls
If an entity file was excessively large, I just decided to split it up for easier navigation through the code
I still do not feel it is there yet, but it is a bit better
Toggling works, but the behavior is very naive and dependent on viewport uniformity
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #115
PR adds basic support for bookmarks. The DB is ready to support bookmarks outside of epub files, however the UI has not been developed for other media types/readers.
Also reorganized a little bit, breaking up really large files (e.g.
db::entity::media) into separate, more focused files.