Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 General housekeeping #225

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

JMicheli
Copy link
Collaborator

  • Update workspace dependencies and added async-trait as a workspace dependency.
  • Update all rust dependencies to latest non-breaking version.
  • Update settings.json because "source.fixAll.eslint" setting was changed to a string value.
  • Change debug_setup in server main.rs to be annotated with cfg(debug_assertions).
  • Address todos in CLI crate, adding prettytable-rs as a dependency.

@aaronleopold
Copy link
Collaborator

Thanks for doing this! I'll be able to give it a quick review sometime tomorrow 👍

Address todos in CLI crate, adding prettytable-rs as a dependency

👏 Awesome

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

During my lunch I checked this branch out locally, merged in develop, and built an image - all looks good so I am comfortable merging 👍

I'll try to get #218 all ready for merge so the nightly CI test can start being helpful

@aaronleopold aaronleopold merged commit f87a4ad into stumpapp:develop Dec 18, 2023
6 of 7 checks passed
@aaronleopold aaronleopold mentioned this pull request Feb 18, 2024
@JMicheli JMicheli deleted the housekeeping branch June 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants