🎨 Refactor core config #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update main with latest develop
This reverts commit b73699c.
aaronleopold
approved these changes
Dec 9, 2023
aaronleopold
approved these changes
Dec 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in Issue #191, Stump currently relies on storing configuration variables in the environment to maintain global state in the application. This is undesirable because 1) it means functions' inputs are not the only thing that determines their behavior, 2) configuration is scattered throughout the repo, and 3) configuration doesn't benefit from Rust's robust validation ecosystem.
To address this, this pull request applies fairly comprehensive changes to the stump_core crate as well as the server app (to maintain compatibility with the changes to the core). All values that were configured with environment variables are still configured with the same environment variables, however, those values are now stored in a
StumpConfigstruct at startup and this struct is maintained in anArcthroughout Stump's runtime.Other than this, the application should behave exactly the same.