Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify scripts to support building on windows #211

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

JMicheli
Copy link
Collaborator

@JMicheli JMicheli commented Dec 8, 2023

Added a Power Shell version of ./scripts/release/build-docker.sh and changed ./scripts/lib to support windows paths in prisma.rs, making it easier for Windows developers to build the Docker container locally.

Copy link
Collaborator

@aaronleopold aaronleopold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Note that the nightly CI always fails for contributor PRs, I'll take the time to fix it over the weekend

@aaronleopold aaronleopold merged commit 563313c into stumpapp:develop Dec 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants